Basic methods v1.9 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal update of current code to work on API 1.9. The module no longer works with API 1.7 due to a different hash function. * Use `SHA256` hashing function for signatures instead of the unsafe `SHA`. * Additional parameters for the API have been added to the `payment_init` function. But the function remains compatible with version 0.7.0. * Functions `oneclick_init` and `oneclick_start` removed. This means that the client implements only Basic Payment. Other payments methods, such as OneClick, will be added later. * Added HTTP return codes 401 and 503 to `HTTP_STATUSES`.
zbohm
force-pushed
the
basic_methods_v1.9
branch
from
29dd926
to
e8495ff
Compare
|
Funkce |
zbohm
force-pushed
the
basic_methods_v1.9
branch
from
e8495ff
to
9e0b027
Compare
|
I'm missing the update of RETURN_CODES as there was quite a few changes in 1.8 and 1.9 judging from changleog |
tdivis
reviewed
Sep 15, 2022
| 403: 'Forbidden', | ||
| 404: 'Not Found', | ||
| 405: 'Method Not Allowed', | ||
| 429: 'Too Many Requests', | ||
| 503: 'Service Unavailable' | ||
| 500: 'Internal Server Error', | ||
| 503: 'Service Unavailable', | ||
| } |
There was a problem hiding this comment.
Is this HTTP_STATUSES variable used anywhere?
There was a problem hiding this comment.
No, it is not in use anywhere yet.
pycsob/client.py
Outdated
| @@ -71,9 +68,10 @@ def payment_init(self, order_no, total_amount, return_url, description, cart=Non | |||
| :param total_amount: | |||
| :param return_url: URL to be returned to from payment gateway | |||
| :param cart: items in cart, currently min one item, max two as mentioned in CSOB spec | |||
| :param description: order description | |||
| :param description: product name | |||
There was a problem hiding this comment.
I would add that it's only used for the cart item name if cart is emtpy.
There was a problem hiding this comment.
There should be changelog entry with incompatible and other changes/migration guide.
There was a problem hiding this comment.
Docstring and Changelog have been updated.
tdivis
approved these changes
Sep 26, 2022
'PyscobSession' -> 'PycsobSession' (as CSOB is the bank name)
'payment/init' request: 'payOperation' with value 'customPayment' and 'customExpiry' items already supported 'payment/init' response: add 'customerCode' item
zbohm
force-pushed
the
basic_methods_v1.9
branch
from
24a7854
to
e13dbc9
Compare
zbohm
force-pushed
the
basic_methods_v1.9
branch
from
e13dbc9
to
d989faf
Compare
* Sign properly complex data Compose message from input data for signing accounting for nested sequences and mappings. * fixup - Correction from code review * fixup - Fix typo * fixup - Fix typo in docstring * fixup - Code review (round 2) * fixup - Add docs comment to enums * fixup - Unnecessary trimming * fixup - strip after trimming * Correction from review - round 3 * fixup - Corrections from review (round 4) * fixup - Change date/time related fields * fixup - Custom formatting should have higher priority * fixup - Add docstrings * Improve type annotations * Use all amounts always as integers * fixup - README and type annotation * fixup - Add enumerations * Remove Python 3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimální aktualizace současného kódu tak, aby fungoval na API 1.9.
Modul kvůli jiné hešovací funkci již nefunguje s API 1.7.
Aktualizace zahrnuje komit z PR #10 opravující zavírání otevřených souborů. Dále zahrnuje PR #11 pro logování komunikace s API.
SHA256místo původníSHA.payment_initdoplněny další paramerty pro API. Funkce ale zůstává kompatibilní s verzí 0.7.0.oneclick_initaoneclick_startodstraněny. Tím je klient uzpůsoben jen k základním metodám. Jiné metody, jako je OneClick, se budou se řešit později.HTTP_STATUSESdoplněny HTTP návratové kódy 401 a 503.Minimal update of current code to work on API 1.9.
The module no longer works with API 1.7 due to a different hash function.
The update includes a commit from PR #10 fixing the closing of open files. It also includes PR #11 for logging communication with the API.
SHA256hashing function for signatures instead of the unsafeSHA.payment_initfunction. But the function remains compatible with version 0.7.0.oneclick_initandoneclick_startremoved. This means that the client implements only Basic Payment. Other payments methods, such as OneClick, will be added later.HTTP_STATUSES.