Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapir.jl Integration #86

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Tapir.jl Integration #86

merged 4 commits into from
Sep 3, 2024

Conversation

willtebbutt
Copy link
Member

Supersedes #71 . Now that rule caching works reasonably well, there is no need to pass around an auxiliary data structure.

@willtebbutt
Copy link
Member Author

This looks like it's working. Good for review at this point.

@yebai yebai mentioned this pull request Sep 2, 2024
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willtebbutt!

@willtebbutt
Copy link
Member Author

If @Red-Portal is happy, I'll merge and tag a release.

@Red-Portal
Copy link
Member

Sorry for the overall delay on the Tapir front. I have been relocating for an internship, which created a huge backlog of other things to do. I'll review the PR today or tomorrow. Amazing work, thank you so much!

@willtebbutt willtebbutt merged commit 87730a0 into master Sep 3, 2024
10 of 11 checks passed
@willtebbutt willtebbutt deleted the wct/tapir branch September 3, 2024 05:58
@willtebbutt willtebbutt self-assigned this Sep 3, 2024
@yebai yebai mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants