Rebase and tweaks to "Fix forcing zones around equator and add force_northern in from_latlon" #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic in from_latlon has been changed to be similar to to_latlon, including adding a force_northern option to mirror northern option in to_latlon. This resolves the issue with northing coordinate incorrectly being set when pasing in -ve or +ve latitude when forcing northern or southern zone respectively. Closes Turbo87#35 - alternative fix for issue.
sdhiscocks
reviewed
Oct 22, 2024
|
Thanks @heathhenley. Just catching up with recent comments. This seems reasonable compromise, raising error when not forcing conversion into a particular hemisphere/zone (see comment regards zone letter). |
heathhenley
force-pushed
the
north_south_fix
branch
from
99b9bde
to
b6d666a
Compare
|
Thanks @sdhiscocks - I just updated based that suggestion. I agree that it makes sense to ignore the checks when forcing the zone. However, it used to raise there (eg this test would raise) so I'm not sure if that's in line what @bartvanandel had in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At attempt at the changes discussed in #46 (comment)
Is something like this what you had in mind @bartvanandel? Or should the checks be explicitly be turned on / off via additional keyword option?
Based on #46