Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inicia implementação do breadcrumb. #57

Merged
merged 10 commits into from
Jul 6, 2024
Merged

Inicia implementação do breadcrumb. #57

merged 10 commits into from
Jul 6, 2024

Conversation

luckslima
Copy link
Contributor

@luckslima luckslima commented Jul 2, 2024

Este PR inclui a visualização do breadcrumb nas views da aplicação, para auxiliar o usuário a se localizar e navegar entre as páginas.

Para implementação dos breadcrumbs, utilizamos a gem Breadcrumbs on Rails, que configura os dados do breadcrumb dentro dos controllers da aplicação. O caminho é exibido nas views, exceto naquelas que compõem do home_controller, através de uma partial.

Foram feitos alguns testes de navegação para a nova funcionalidade.

Tela de cadastro de condomínio, com breadcrumb:
image

Navegação entre as páginas da aplicação usando os breadcrumbs:
Gravação de Tela 2024-07-04 204614

Resolve Issue #52

@luckslima luckslima added the enhancement New feature or request label Jul 2, 2024
@thalytalima211 thalytalima211 marked this pull request as ready for review July 5, 2024 19:12
@thalytalima211 thalytalima211 linked an issue Jul 5, 2024 that may be closed by this pull request
Copy link
Contributor

@RyanOxon RyanOxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei pre-aprovado mas deixei alguns comentarios que seria legal dar uma olhada!

app/controllers/common_areas_controller.rb Outdated Show resolved Hide resolved
app/views/shared/_breadcrumb.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@ruliancruz ruliancruz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei alguns comentários com sugestões para melhoria do código, mas são detalhes, de resto não vi nada de errado na implementação, por isso tem minha aprovação.

app/controllers/units_controller.rb Show resolved Hide resolved
spec/system/user_sees_breadcrumb_spec.rb Show resolved Hide resolved
@luckslima luckslima merged commit 495d838 into main Jul 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criar barra de caminho de navegação
4 participants