Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Top-Level examples/ Directory #1470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Nov 10, 2024

Description

We need to include a top-level examples directory.

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

Copy link
Member

@aaronmondal aaronmondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

:lgtm:

Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and pending CI: Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, Web Platform Deployment / macos-14, Web Platform Deployment / ubuntu-24.04, docker-compose-compiles-nativelink (22.04), macos-13, pre-commit-checks, windows-2022 / stable, and 2 discussions need to be resolved


-- commits line 2 at r1:
nit: "Ensure"


local-remote-execution/README.md line 195 at r1 (raw file):

Start the cluster and set up NativeLink in an LRE configuration. For details on
this refer to the [Kubernetes example](https://github.com/tracemachina/nativelink/tree/main/deployment-examples/kubernetes):

nit: This one should probably point to https://www.nativelink.com/docs/deployment-examples/kubernetes


local-remote-execution/README.md line 246 at r1 (raw file):

resources:
  - https://github.com/TraceMachina/nativelink//examples/kubernetes/base

fyi I need to revisit this one as it's outdated. Not much we can do in this pr though.

@MarcusSorealheis MarcusSorealheis changed the title Ensures Top-Level examples/ Directory Ensure Top-Level examples/ Directory Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants