Move custom tekton resources to the operator #1446
Conversation
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 14 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-13, Bazel Dev / macos-14, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-13, Cargo Dev / ubuntu-22.04, Coverage, Installation / macos-13, Installation / macos-14, Installation / ubuntu-22.04, Local / ubuntu-22.04, NativeLink.com Cloud / Remote Cache / macos-14, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / large-ubuntu-22.04, asan / ubuntu-22.04, docker-compose-compiles-nativelink (22.04), integration-tests (22.04), macos-13, pre-commit-checks, ubuntu-20.04 / stable, ubuntu-22.04, ubuntu-22.04 / stable, vale, windows-2022 / stable (waiting on @SchahinRohani)
aaronmondal
had a problem deploying
to
production
GitHub Actions
Error
aaronmondal
changed the title
aaronmondal
force-pushed
the
move-rebuild-nativelink
branch
from
2c93419
to
01233d3
Compare
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
force-pushed
the
move-rebuild-nativelink
branch
from
01233d3
to
82302f1
Compare
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
aaronmondal
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1, all commit messages.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
native-cli/components/capacitor.go line 23 at r1 (raw file):
// Install sets up the Capacitor dashboard. func (component *Capacitor) Install(
nit: why did you move capacitor out of the kustomization into a pulumi resource?
There was a problem hiding this comment.
Reviewable status: 1 of 1 LGTMs obtained, and all files reviewed, and 1 discussions need to be resolved
native-cli/components/capacitor.go line 23 at r1 (raw file):
Previously, SchahinRohani (Schahin) wrote…
nit: why did you move capacitor out of the kustomization into a pulumi resource?
This allowed me to remove rebuild-nativelink.go where it was previously wrongly deployed via pulumi as part of the rebuild-nativelink kustomization.
This change is