Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin interface to be compatible with newer Keyboardio API. #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bjc
Copy link

@bjc bjc commented Aug 14, 2018

No description provided.

@mgsloan
Copy link

mgsloan commented Sep 3, 2018

Please merge! I just implemented the same changes. I should have checked the PRs

@cdata
Copy link

cdata commented Sep 25, 2018

Ditto, just made the same changes myself before checking the PRs :'( hopefully the maintainer is still around?

@cdata
Copy link

cdata commented Sep 25, 2018

BTW, the migration guide also suggested changing millis() to Kaleidoscope.millisAtCycleStart() (reference)

It was a trivial change: master...cdata:master

kevinr added a commit to kevinr/Kaleidoscope-LED-Fire that referenced this pull request Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants