Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue673 si units rc #687

Open
wants to merge 19 commits into
base: devel
Choose a base branch
from
Open

Issue673 si units rc #687

wants to merge 19 commits into from

Conversation

adriendaros
Copy link
Collaborator

Motivations:

Use an adequat format to describe the units of the physical quantity involved in the file tofu/spectro/_rockingcurve_def.py

Results:

Choice to use the library scipy.constants, in a first time, to allocate the unit in a String format.
The next step will be to change into an astropy.units format, more convenient to use (not String format)

Issues:

Fixes, in devel, issue #673

Examples:

image
image

@adriendaros adriendaros self-assigned this Oct 12, 2022
@adriendaros adriendaros changed the title Issue673 s iunits rc Issue673 si units rc Dec 12, 2022
@adriendaros
Copy link
Collaborator Author

Issue fixed in ToFuProject/datastock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants