-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update @CascadingUpdateShadowVariable models #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@triceo, it looks like the CI is fetching the development branch instead of the PR branch. I moved the checkout step to the beginning of the script to see if it fixes the issue. |
triceo
reviewed
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the var dependencies.
java/food-packaging/src/main/java/org/acme/foodpackaging/domain/Job.java
Outdated
Show resolved
Hide resolved
zepfred
force-pushed
the
cascade-perf-6
branch
from
August 12, 2024 14:21
5c69a83
to
91a9c6f
Compare
triceo
approved these changes
Aug 12, 2024
zepfred
force-pushed
the
cascade-perf-6
branch
from
August 12, 2024 15:10
67ae170
to
6adaa77
Compare
zepfred
force-pushed
the
cascade-perf-6
branch
from
August 12, 2024 15:12
6adaa77
to
41eade4
Compare
zepfred
force-pushed
the
cascade-perf-6
branch
from
August 12, 2024 16:38
ba297cf
to
e47ef13
Compare
zepfred
force-pushed
the
cascade-perf-6
branch
from
August 12, 2024 17:19
e47ef13
to
23c5c29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This pull request updates the models of
food-packaging
,task-assigning
, andvehicle-routing
to match the changes from TimefoldAI/timefold-solver#1020.Checklist
Development
Code Review