🐛 Fix async pending error #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please avoid formatting the code you are not touching. |
fuergaosi233
force-pushed
the
fix/fix-async-error
branch
from
b1268ff
to
994a6e9
Compare
aisk
reviewed
May 28, 2024
thriftpy2/contrib/aio/socket.py
Outdated
| def set_handle(self, sock): | ||
| self.raw_sock = sock | ||
|
|
||
| def set_timeout(self, ms): |
There was a problem hiding this comment.
I think we still can implement this method, just set the instance fields, which can be used in open and read methods.
ethe
reviewed
Jul 25, 2024
| async def open(self): | ||
| addr = self.unix_socket or (self.host, self.port) | ||
| try: | ||
| if self.unix_socket: |
There was a problem hiding this comment.
use self.socket_factory instead, see https://github.com/Thriftpy/thriftpy2/pull/271/files#diff-19812d639b869b73a1158c80d996c6fa56787f93905759034caac0381ed7f8fdR82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #270