-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable scrolling for custom layout #103
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce a new Changes
Sequence Diagram(s)sequenceDiagram
actor User
User->>Swiper: Interacts with Swiper
Swiper->>_SwiperState: Initialize with allowScrolling
_SwiperState->>_CustomLayoutSwiper: Constructor with allowScrolling
alt allowScrolling is true
_CustomLayoutSwiper->>GestureDetector: Enable onPanStart, onPanEnd, onPanUpdate
GestureDetector-->>Swiper: Handle gestures as usual
else allowScrolling is false
_CustomLayoutSwiper-->>GestureDetector: Disable onPanStart, onPanEnd, onPanUpdate
GestureDetector-->>User: Scrolling disabled
end
Swiper-->>User: Display Swiper with updated scrolling behavior
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- lib/src/custom_layout.dart (3 hunks)
- lib/src/swiper.dart (9 hunks)
Additional comments not posted (6)
lib/src/custom_layout.dart (2)
10-10
: LGTM!The new getter
_allowScrolling
correctly derives its value fromwidget.allowScrolling
.
124-126
: LGTM!The
GestureDetector
callbacks are correctly updated to conditionally execute based on_allowScrolling
.lib/src/swiper.dart (4)
75-75
: LGTM!The new parameter
allowScrolling
is correctly added to theSwiper
constructor with a default value oftrue
.
122-122
: LGTM!The new parameter
allowScrolling
is correctly added to theSwiper.children
factory constructor with a default value oftrue
.
253-254
: LGTM!The new final field
allowScrolling
is correctly added to theSwiper
class and initialized in the constructor.
288-288
: LGTM!The new parameter
allowScrolling
is correctly added to theSwiper.list
factory constructor with a default value oftrue
.
Merge this |
A new functionality that allows to users to disable scrolling for the custom layout.
Summary by CodeRabbit
allowScrolling
option to customize scrolling behavior in the swiper widget.allowScrolling
setting, allowing for more flexible user interactions.