Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid padding a struct to be hashed #2024

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wsdwsd0829
Copy link
Contributor

alternatively

  • (NSUInteger)hash
    {
    #pragma pack(push,1)
    struct {
    CGSize viewportSize;
    ASScrollDirection scrollableDirections;
    NSUInteger elementsHash;
    NSUInteger layoutDelegateClassHash;
    NSUInteger additionalInfoHash;
    } data = {
    _viewportSize,
    _scrollableDirections,
    _elements.hash,
    _layoutDelegateClass.hash,
    [_additionalInfo hash]
    };
    #pragma pack(pop)
    return ASHashBytes(&data, sizeof(data));
    }

I am less confident about what #pragma pack(push,1) is doing

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rcancro
Copy link
Contributor

rcancro commented Sep 17, 2021

Let's try these things and see if they work:

  • Try setting the values of the struct explicitly like the comment in ASHashBytes suggests
  • Try changing the type of ASScrollDirection from unsigned char to NSUInteger

If neither of those work, let's land this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants