avoid padding a struct to be hashed #2024
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternatively
{
#pragma pack(push,1)
struct {
CGSize viewportSize;
ASScrollDirection scrollableDirections;
NSUInteger elementsHash;
NSUInteger layoutDelegateClassHash;
NSUInteger additionalInfoHash;
} data = {
_viewportSize,
_scrollableDirections,
_elements.hash,
_layoutDelegateClass.hash,
[_additionalInfo hash]
};
#pragma pack(pop)
return ASHashBytes(&data, sizeof(data));
}
I am less confident about what #pragma pack(push,1) is doing