Fix Surefire missing NPE Issue #154
Conversation
| @@ -181,7 +181,9 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| this.surefire = this.lookupPlugin("org.apache.maven.plugins:maven-surefire-plugin"); | |||
|
|
|||
| if (this.surefire == null) { | |||
| Logger.getGlobal().log(Level.SEVERE, "Make sure surefire is in your pom.xml"); | |||
| Logger.getGlobal().log(Level.SEVERE, "Surefire is not explicitly declared in your pom.xml;" | |||
| + " we will use version 2.20, but you may want to change that."); | |||
There was a problem hiding this comment.
Surefire version seems to be updated to 2.22.2 instead of 2.20 as for NonDex itself.
Here I suppose the surefire version 2.20 is for the project NonDex intends to run upon. I am not sure whether 2.20 is the best choice.
It seems that a more recent surefire version (e.g., 3.0.0-M4) will be better, for both NonDex itself and the project under test, because it claims to provide better support for JUnit5. Please refer to https://maven.apache.org/surefire/maven-surefire-plugin/
There was a problem hiding this comment.
I guess we picked 2.20 becuase all sub-modules in integration tests use it.
Sure. I agree that upgrade Surefire for all modules or NonDex and even the running project to the most recent surefire version (e.g.3.0.0-M5) is better.
I just updated the fallback version in this PR and I'll do it for the other pom.xml in another.
…ed in pom.xml & Use surefire fallback version 3.0.0-M5
ShawnLi-25
force-pushed
the
surefire-npe-error-fix
branch
from
60120c1
to
96c622b
Compare
|
Kaiyao confirmed via email that this functionality is included in the accepted big PR. |
#89