Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy-Authorization added #59

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dtalkachou
Copy link

@dtalkachou dtalkachou commented Mar 8, 2021

I think it's an important feature because not always people have an unauthorized proxy.

We had the following error before:

scrapy.core.downloader.handlers.http11.TunnelError: Could not open CONNECT tunnel with proxy <proxy> [{'status': 407, 'reason': b'Proxy Authentication Required'}]

Please, update PyPI after merging this request.

@dkarelov
Copy link

Thanks, confirm it is working!

@8W9aG
Copy link

8W9aG commented Jul 24, 2021

Thanks for this, can confirm its a big issue, this is forcing me to use forks rather than the main package

@dtalkachou
Copy link
Author

@StasDeep, is it possible to merge and close this PR. Seems like it's an actual problem for some engineers.

@StanHENI
Copy link

@dtalkachou I don't have merge permissions on this repository.
@kmike ?

@kmike
Copy link
Contributor

kmike commented Feb 18, 2022

Unfortunately I lost permissions myself :( We should probably fork this repo to another place, likely scrapy-plugins.

@dtalkachou
Copy link
Author

@kmike, Is there anybody else who has permissions?

@divtiply
Copy link

divtiply commented Jun 7, 2022

Proxy-Authorization header is set by Scrapy built-in HttpProxyMiddleware. @dtalkachou do you have it enabled?

@dtalkachou
Copy link
Author

Seems like I didn't have it enabled.

Yes, after code reading I think that HTTPPROXY_ENABLED = True should solve the problem. If somebody checks this approach, let me know. And provide more details for developers who will have the same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants