use right trigger error level for deprecations

Sysix · Dec 8, 2023 · d8c51ad · d8c51ad
1 parent dfe93b5
commit d8c51ad
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/src/BaseClient.php b/src/BaseClient.php
@@ -20,7 +20,7 @@ public function __construct(
      */
     public function getAsJson(ResponseInterface $response): object
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, use \Sysix\LexOffice\Utils::getJsonFromResponse instead', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, use \Sysix\LexOffice\Utils::getJsonFromResponse instead', E_USER_DEPRECATED);
 
         $body = $response->getBody()->__toString();
 

diff --git a/src/Clients/Traits/VoucherListTrait.php b/src/Clients/Traits/VoucherListTrait.php
@@ -12,7 +12,7 @@ trait VoucherListTrait
      */
     public function getPage(int $page): ResponseInterface
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_DEPRECATED);
 
         $client = new VoucherList($this->api);
         $client->setToEverything();
@@ -26,7 +26,7 @@ public function getPage(int $page): ResponseInterface
      */
     public function getAll(): ResponseInterface
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_DEPRECATED);
 
         $client = new VoucherList($this->api);
         $client->setToEverything();

diff --git a/src/Clients/Voucher.php b/src/Clients/Voucher.php
@@ -45,7 +45,7 @@ public function upload(string $id, string $filepath): ResponseInterface
      */
     public function getAll(): ResponseInterface
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_DEPRECATED);
 
         $client = new VoucherList($this->api);
 
@@ -54,7 +54,7 @@ public function getAll(): ResponseInterface
          */
         $client->statuses = ['open', 'paid', 'paidoff', 'voided', 'transferred', 'sepadebit'];
         $client->types = ['salesinvoice', 'salescreditnote', 'purchaseinvoice', 'purchasecreditnote'];
-
+    
         return $client->getAll();
     }
 }
diff --git a/src/Clients/VoucherList.php b/src/Clients/VoucherList.php
@@ -39,7 +39,7 @@ class VoucherList extends PaginationClient
      */
     public function setToEverything(): self
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_DEPRECATED);
 
         $this->types = [
             'salesinvoice',

diff --git a/src/PaginationClient.php b/src/PaginationClient.php
@@ -38,7 +38,7 @@ public function getPage(int $page): ResponseInterface
      */
     public function getAll(): ResponseInterface
     {
-        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_WARNING);
+        trigger_error(self::class . '::' . __METHOD__ . ' should not be called anymore, in future versions this method WILL not exist', E_USER_DEPRECATED);
 
         $response = $this->getPage(0);
         /** @var ?stdClass{totalPages:int, content:stdClass[]} $result */

diff --git a/tests/TestClient.php b/tests/TestClient.php
@@ -95,7 +95,7 @@ public function expectDeprecationV1Warning(string $method): void
     {
         set_error_handler(static function (int $errno, string $errstr): void {
             throw new  DeprecationException($errstr, $errno);
-        }, E_USER_WARNING);
+        }, E_USER_DEPRECATED);
 
         $this->expectException(DeprecationException::class);