Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sip366 feedback - lock intent to delegate collateral #2244

Open
wants to merge 12 commits into
base: SIP-366-implementation
Choose a base branch
from
Open

Sip366 feedback - lock intent to delegate collateral #2244

wants to merge 12 commits into from

Conversation

leomassazza
Copy link
Contributor

@leomassazza leomassazza commented Aug 29, 2024 •
edited
Loading

Fixes:

  • H - Current design may not prevent JIT liquidity attacks
  • M - Intents not cleared on vault liquidation
  • L - Pending intents should be cleared when an account is transferred
    some extra cleanup on comments

@leomassazza leomassazza changed the title Split net to total delegate and undelegate [WIP] Sip366 feedback - lock intent to delegate collateral Aug 29, 2024
@leomassazza leomassazza changed the title [WIP] Sip366 feedback - lock intent to delegate collateral Sip366 feedback - lock intent to delegate collateral Sep 2, 2024
@leomassazza leomassazza marked this pull request as ready for review September 2, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leomassazza