Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ fix: Properly exported Cypress for metamask #1207

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

matstyler
Copy link
Collaborator

Motivation and context

Cypress for Metamask properly exported from the Synpress

Quality checklist

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough e2e tests.

⚠️👆 Delete any section you see irrelevant before submitting the pull request 👆⚠️

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synpress ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 26, 2024 10:51am

@matstyler matstyler changed the title fix: Properly exported Cypress for metamask ♻️ fix: Properly exported Cypress for metamask Aug 26, 2024
@@ -15,7 +15,7 @@
},
"dependencies": {
"@playwright/test": "1.44.0",
"@synthetixio/synpress": "4.0.0-alpha.9",
"@synthetixio/synpress": "workspace:*",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matstyler matstyler requested a review from drptbl August 27, 2024 10:20
@drptbl drptbl merged commit a54e71f into new-dawn Aug 31, 2024
9 of 11 checks passed
@drptbl drptbl deleted the chore/cypress-with-metamask-exports branch August 31, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants