Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and enhance the tax provider #298

Open
wants to merge 2 commits into
base: 1.6
Choose a base branch
from

Conversation

maikrosenthal
Copy link

Q A
Branch? 1.6 (bug fixes, improvements)
Bug fix? yes
New feature? no

This PullRequest fixes or changes the following aspects of the taxes to be submitted to PayPal:

  1. The OrderItemNonNeutralTaxesProvider determines both the TaxAdjustemts of the OrderItem and the respective TaxAdjustemts of all units and adds their amounts to an array. The PayPalItemDataProvider then iterates over these amounts and creates an item with quanity 1, unitPrice and tax. However, since an item can also have a quantity higher than 1, the totals no longer match in such a case.

To fix this error, the TaxAdjustments of the OrderItems are distributed to the respective units.

  1. The OrderItemNonNeutralTaxesProvider only determines the non-neutral taxes. In order to transmit all taxes, the neutral taxes are also determined and processed.

Unfortunately, I am not a professional when it comes to tax law in different countries. Therefore, I would be grateful for any feedback if any problems arise.

@maikrosenthal maikrosenthal changed the title Fixed and enhanced the tax provider Fix and enhanced the tax provider Jun 19, 2024
@maikrosenthal maikrosenthal changed the title Fix and enhanced the tax provider Fix and enhance the tax provider Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant