Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whitespace according to style guide #1111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kaveeshakavindi
Copy link

@Kaveeshakavindi Kaveeshakavindi commented Mar 27, 2023

Description

This commit removes the extra white space from the codebase, which was identified as not following the project's style guide. The changes were made to the files affected by the issue #1110 . This change improves code readability and consistency across the project.

Fixes #(issue)

Type of change

Just put an x in the [] which are valid.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • ./gradlew assembleDebug assembleRelease
  • [x ] ./gradlew checkstyle

Checklist:

  • [ x] My code follows the style guidelines of this project
  • [x ] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [x ] I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings

@codeclimate
Copy link

codeclimate bot commented Mar 27, 2023

Code Climate has analyzed commit 0452921 and detected 0 issues on this pull request.

View more on Code Climate.

@@ -0,0 +1,15 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be checked in.

@@ -157,6 +157,5 @@ public TextToPDFOptions build() {
mPassword, mInFileUri, mFontSize, mFontFamily, mFontColor, mPageColor);
}


Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are fixing whitespaces, it would be better to do it for whole repository. Changing it for just 1 file isn't that helpful. Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants