Fatal flags #24
Open
Fatal flags #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new type of Flag called Fatal. This is an extended Bad flag (integer value 44), that indicates that a record is so bad that it can't be processed properly and/or there is no possible way to rectify it (e.g. latitude/longitude out of range).
I have also added a new method called getWoceValue. This converts the internal flag values to WOCE values. So Assumed Good gets converted to 2 (Good), and Fatal gets converted to Bad (4). This saves other code having to do the logic itself. Some of the Flag values (Ignore, Not set etc.) can't be converted to WOCE values, so they get -1. You can check these as required.
I don't think the SOCAT code is affected by any of this, so it should pull straight into the master branch with no issues. Just to be on the safe side I'm submitting it for you to review...
I've updated the Java compiler compliance to 1.8 in the Eclipse files, and done a little bit of Javadoc. I've started going back through old code and doing that, but it will come slowly.