Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings with spelling mistakes #377

Open
TheSparrowLenz opened this issue Jan 5, 2021 · 1 comment
Open

Strings with spelling mistakes #377

TheSparrowLenz opened this issue Jan 5, 2021 · 1 comment

Comments

@TheSparrowLenz
Copy link
Contributor

TheSparrowLenz commented Jan 5, 2021

Well these are just annoying AF.

SUBTITLES_CHANGE_ACIVE <=> SUBTITLES_CHANGE_ACTIVE
WEBSITE_ADDONS_TWICH <=> WEBSITE_ADDONS_TWITCH
WEBSITE_ADDONS_WATCHUB <=> WEBSITE_ADDONS_WATCHHUB
WEBSITE_TECHNOLOGY_CONTRIBUTE_P_TRANSALTE <=> WEBSITE_TECHNOLOGY_CONTRIBUTE_P_TRANSLATE
WEBSITE_LINK_PRAVACY <=> WEBSITE_LINK_PRIVACY
WEBSITE_LINK_PRAVACY_LEGAL <=> WEBSITE_LINK_PRIVACY_LEGAL
WEBSITE_ENJOI_ON_ALL_DEVICES <=> WEBSITE_ENJOY_ON_ALL_DEVICES

Then there is:
"WEBSITE_TRANSLATE_STREMIO": "Translate Stremio" and "WEBSITE_TRANSALTE_STREMIO": "Translate Stremio",
Guess this has been fixed by adding a new string but can the old one with bad spelling be deleted?

These strings will need to be changed in ALL translation files and will probably need to be changed in the code unless they're mentioned correctly in there, in which case these strings are useless in their current form and they constitute a bug.

@TheSparrowLenz TheSparrowLenz changed the title "SUBTITLES_CHANGE_ACIVE" Strings with spelling mistakes Jan 5, 2021
@Florian-Mahlberg
Copy link

Hey,
I created a pull request in branch new-add-on-string with a correction of the string names.
I didn't knew, where I these string names were used in the code, so I didn't did that yet.
I hope I helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants