Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document support for the Java platform logger #892

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Document support for the Java platform logger #892

wants to merge 1 commit into from
+6 −1

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Jan 28, 2022

This is a companion to SpongePowered/Sponge#3608, targeting api-9.

@zml2008 zml2008 added this to the v9.0.0 milestone Jan 28, 2022
ST-DDT
ST-DDT approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe we should create an API-9 branch (like we did for api8)

@felixoi
Copy link
Member

felixoi commented Feb 4, 2022

Don't merge this to stable. Create an api-9 branch please.

@Inscrutable
Copy link
Member

I think we can safely abandon the idea of API-9 docs, we barely had any releases for it.
This can be bumped forward to Sponge API-10.

@Inscrutable Inscrutable modified the milestones: v9.0.0, v10.0.0 May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zml2008 @felixoi @Inscrutable @ST-DDT