chore: merge ledgerhq updates

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,8 @@
+# Checklist
+<!-- Put an `x` in each box when you have completed the items. -->
+- [ ] App update process has been followed <!-- See comment below -->
+- [ ] Target branch is `develop` <!-- unless you have a very good reason -->
+- [ ] Application version has been bumped <!-- required if your changes are to be deployed -->
+
+<!-- Make sure you followed the process described in https://developers.ledger.com/docs/embedded-app/maintenance/ before opening your Pull Request.
+Don't hesitate to contact us directly on Discord if you have any questions ! https://developers.ledger.com/discord -->

Makefile

@@ -24,7 +24,8 @@ include $(BOLOS_SDK)/Makefile.defines
 ########################################
 #        Mandatory configuration       #
 ########################################
-APP_LOAD_PARAMS += --tlvraw 9F:01
+
+ENABLE_PENDING_REVIEW_SCREEN = 1
 
 # Application name
 APPNAME = "Solar"

ledger_app.toml

@@ -0,0 +1,4 @@
+[app]
+build_directory = "./"
+sdk = "C"
+devices = ["nanos", "nanox", "nanos+"]

src/apdu/dispatcher.c

@@ -38,7 +38,7 @@
 
 #include "constants.h"
 #include "sw.h"
-#include "types.h"
+#include "app_types.h"
 
 #include "handler/get_version.h"
 #include "handler/get_app_name.h"

src/apdu/dispatcher.h

@@ -2,7 +2,7 @@
 
 #include "parser.h"
 
-#include "types.h"
+#include "app_types.h"
 
 /**
  * Parameter 2 for last APDU to receive.

src/app_main.c

@@ -25,7 +25,7 @@
 #include "context.h"
 #include "globals.h"
 #include "sw.h"
-#include "types.h"
+#include "app_types.h"
 
 #include "apdu/dispatcher.h"
 

src/globals.h

@@ -6,7 +6,7 @@
 #include "ux.h"
 
 #include "constants.h"
-#include "types.h"
+#include "app_types.h"
 
 /**
  * Global buffer for interactions between SE and MCU.

src/handler/get_address.c

@@ -44,7 +44,7 @@
 #include "context.h"
 #include "globals.h"
 #include "sw.h"
-#include "types.h"
+#include "app_types.h"
 
 #include "crypto/crypto.h"
 #include "helper/send_response.h"

src/handler/get_app_name.c

@@ -36,7 +36,7 @@
 
 #include "constants.h"
 #include "sw.h"
-#include "types.h"
+#include "app_types.h"
 
 int handler_get_app_name() {
     _Static_assert(APPNAME_LEN < APPNAME_MAX_LEN, "APPNAME must be at most 64 characters!");

src/handler/get_public_key.c

@@ -42,7 +42,7 @@
 
 #include "context.h"
 #include "globals.h"
-#include "types.h"
+#include "app_types.h"
 #include "sw.h"
 
 #include "crypto/crypto.h"

src/handler/get_version.c

@@ -39,7 +39,7 @@
 
 #include "constants.h"
 #include "sw.h"
-#include "types.h"
+#include "app_types.h"
 
 int handler_get_version() {
     _Static_assert(APPVERSION_LEN == 3, "Length of (MAJOR || MINOR || PATCH) must be 3!");

src/ui/transactions/vote_display.c

@@ -17,7 +17,7 @@
 #include "read.h"
 
 #include "constants.h"
-#include "types.h"
+#include "app_types.h"
 
 #include "transaction/transaction_utils.h"
 #include "transaction/types/vote.h"