-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WorkAround.java #1688
base: master
Are you sure you want to change the base?
Update WorkAround.java #1688
Conversation
Fixed missing quotes for ARDUINO_HOST_OS, ARDUINO_FQBN and ARDIONO_VARIANT that prevent compiling.
Added backslashes I missed on the previous fix.
This is a very tricky part of the code as all platforms are a bit different. |
When compiling two different ESP32 boards with multiple sketches using the latest ardiono-esp32 core I was getting an error. I had previously reported this bug, #1649. This seams to fix the bug. I noticed the problem when I realized that sloeber makes a modified version of the platform.txt file and almost all of the variables with quotes had the added backslash, but those three that were causing a failure to compile did not have the backsplash even though they had quotes. Seemed like a pretty obvious fix, so I modified the platform.sloeber.txt file and then it compiled. I then searched the code for the part that makes that file and added lines similar to the already existing ones to replace the quotes with three backslashes and a quote just like the other ones above it in the code. |
Fixed typo, changed . to _
Updated FIRST_SLOEBER_WORKAROUND_LINE to say test 26
My apologies, someone when I typed the changed on no sleep, I hit the period instead of underscore on 2 out of 3 lines. I corrected that. Also updated that to say test 26 as you mentioned. As far as testing it, I have not tested compiling because I don't have a suitable environment to compile right now. I was thinking about setting up a virtual machine just for it. But I tested the changes that the added code makes and it worked, so the proposed changes seemed obvious based on your existing code. I just had some typos unfortunately. Hopefully the change should be good now. |
It looks to me you tested with sloeber v4.X and made the changes to V5.X and according to my tests the changes are not needed in V5 as lots of ESP32 problems should be fixed in there. |
Indeed I still need to change the image.
This is caused by an error in the perspectives which makes Sloeber not to be the perspective. Trying to fix this now.
The video seems to be marked private. I can't see it. |
Fixed missing quotes for ARDUINO_HOST_OS, ARDUINO_FQBN and ARDUINO_VARIANT that prevent compiling.