Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not dropping sensitive blocks once and for all #4200

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

EpicPlayerA10
Copy link
Contributor

@EpicPlayerA10 EpicPlayerA10 commented May 30, 2024

Description

Fixed not dropping sensitive blocks once and for all

Proposed changes

This PR takes a different approach from all other solutions. It listens for BlockPhysicsEvent which fires before block update. Inside listener it checks if block can be placed in the location where event was fired. This is the best method to listen for collapsing sensitive blocks without a headache with SENSITIVE_MATERIALS tag.

The only downside of this solution is that it require at least version 1.18 because it uses BlockData#isSupported method.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@EpicPlayerA10 EpicPlayerA10 requested a review from a team as a code owner May 30, 2024 13:06
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label May 30, 2024
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented May 30, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: fefff5b6

https://preview-builds.walshy.dev/download/Slimefun/4200/fefff5b6

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@JustAHuman-xD JustAHuman-xD self-assigned this Jun 3, 2024
@TheBusyBot TheBusyBot added the ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved! label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue. ⚡ Merge Conflicts This Pull Request has merged conflicts which need to be resolved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants