Allow configuration of securityContext for PSA/PSS usage #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maruina
approved these changes
Nov 12, 2023
maruina
approved these changes
Nov 25, 2023
|
@derbauer97 I can't approve PRs anymore, but @Smirl or @gjtempleton can have a look |
gjtempleton
reviewed
Nov 27, 2023
| @@ -15,7 +15,7 @@ type: application | |||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| # Versions are expected to follow Semantic Versioning (https://semver.org/) | |||
| version: 1.0.2 | |||
| version: 1.0.3 | |||
There was a problem hiding this comment.
Can we make this a minor version bump as we're adding new functionality?
| @@ -68,9 +68,9 @@ spec: | |||
| resources: | |||
| {{- toYaml .Values.resources | nindent 12 }} | |||
| securityContext: | |||
| allowPrivilegeEscalation: false | |||
| {{- toYaml .Values.containerSecurityContext | nindent 12 }} | |||
There was a problem hiding this comment.
This appears to be over-indenting by 2.
Comment on lines
+58
to
+59
| # Specifies Container Security Context | ||
| containerSecurityContext: |
There was a problem hiding this comment.
Can we make this a bit more specific, as it only applies to the manager container, not the kube-rbac-proxy container if enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Migration to PSS/PSA you need to set certain settings in securityContext in pod or and container security Context. Therefore i added the option to set these via helmvalues.
Reference: https://kubernetes.io/docs/concepts/security/pod-security-standards/