Add regex to aggregate equation operators #91
Conversation
This operator was introduced in 10.1.8 by RN30199. See https://docs.dataminer.services/develop/devguide/Connector/Actions/ActionAggregate.html#equation
|
| @@ -1747,7 +1747,7 @@ public List<IValidationResult> CheckTrendAlarm(XmlDocument xDoc) // M | |||
| /// <param name="xmlNsm">The namespace.</param> | |||
| private void CheckActionAttributes(XmlDocument xDoc, List<IValidationResult> resultMsg, XmlNamespaceManager xmlNsm) | |||
| { | |||
| string[] operators = { "<", ">", "==", "<=", ">=", "!=", "<", ">", "<=", ">=" }; | |||
| string[] operators = { "<", ">", "==", "<=", ">=", "!=", "<", ">", "<=", ">=", "regex" }; | |||
There was a problem hiding this comment.
Due to the if on line 1960, a false positive will be thrown as regex apparently doesn't need to have an ID which the check doesn't take in account.
Same for the 'equationValue' on line 2041.
|
6247f43 |
I would suggest to skip the error message. If this needs to be improved, the check needs to be converted to the new format. The intention is not to introduce new error messages in the legacy code, only fixes. |
Only skip the validation if no valid regex attribute is found, otherwise give the same invalid syntax error.
Removed new error message in cb5534e |
This operator was introduced in 10.1.8 by RN30199.
See https://docs.dataminer.services/develop/devguide/Connector/Actions/ActionAggregate.html#equation