change: remove obsolete code #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJtheRedstoner
requested changes
Jul 12, 2023
src/main/java/club/sk1er/patcher/mixins/features/GuiPlayerTabOverlayMixin_ReadablePing.java
Outdated
Show resolved
Hide resolved
This has not been relevant since Essential's full release, from what I can tell
calcastor
changed the title
snoopchallenge
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
i have no idea whether this is used or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a set of commits mostly consisting of changes I have made to my local build of Patcher over time.The first commit removes code that seems to have been made irrelevant by changes to the full release of Essential last year.The second commit simply uses ElementaVersion.V2 where possible; I haven't noticed any issues from this over the last several months or so but perhaps I have overlooked something.The third commit contains some purely aesthetic changes, hiding the readable ping value in tab if it is the default 9999 that seems to be used when there is not a valid ping value. It also changes the duplicate message counter to be shown as[x2]rather than(2); I would personally consider this to be more clear but it is not a very necessary change to be honest, mostly my own personal preference.If wanted/needed, I can split these commits into separate PRs. I figured that I might as well see if these were wanted changes since I've sort of just had them sitting around for some time now.This now just drops seemingly obsolete code.