Warn when Tapioca is executed without Bundler #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
force-pushed
the
ko/check-for-bundler
branch
from
43a5f86
to
e9f5265
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
23
to
26
| unless ENV["BUNDLER_VERSION"] | ||
| puts "Warning: You're running tapioca without Bundler. This isn't recommended and may cause issues."\ | ||
| " Please use the provided binstub through `bin/tapioca` instead." | ||
| end |
There was a problem hiding this comment.
ENV['BUNDLER_VERSION'] is not a reliable indicator of Bundler being active, as it may be unset even when running under Bundler. Two more reliable alternatives are:
- Check
ENV['BUNDLE_GEMFILE'], which Bundler consistently sets - Check
defined?(Bundler)to detect if Bundler is loaded
Either approach would prevent false warnings in valid Bundler environments.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
I'm pretty sure BUNDLER_VERSION will be set https://github.com/rubygems/rubygems/blob/c46bf736318a41354c9e411c127247c764dff4ab/bundler/lib/bundler/shared_helpers.rb#L305
But we can do defined?(Bundler) too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses the finding in #1934 (comment)
Implementation
Print a warning as early as possible. Looking at various env variables
BUNDLER_VERSIONfelt like a safe bet.Tests
Tested manually. I can add it if wanted.