Various CI fixes #2074
Draft
Various CI fixes #2074
+551
−463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
force-pushed
the
ko/fix-ci-4
branch
from
d4ced12
to
d997aaf
Compare
KaanOzkan
commented
Nov 14, 2024
Gemfile
Outdated
| @@ -35,7 +35,7 @@ group :development, :test do | |||
| gem "sprockets" | |||
| gem "state_machines" | |||
| gem "activerecord-typedstore" | |||
| gem "sqlite3", "~>1.4" | |||
| gem "sqlite3" | |||
There was a problem hiding this comment.
I'm hoping the issue in #1875 (which I don't know) is resolved by now. We can't constraint it due to https://github.com/rails/rails/blob/main/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
KaanOzkan
commented
Nov 14, 2024
| @@ -1287,6 +1287,7 @@ module Foo; end | |||
| class Foo::Engine < ::Rails::Engine | |||
| class << self | |||
| def __callbacks; end | |||
| def __callbacks=(new_value); end | |||
There was a problem hiding this comment.
I couldn't find where this is defined in Rails but I think it's a safe change
There was a problem hiding this comment.
This definition is flaky. It looks like a normal class_attribute so it should always be there 🤷 . There's a recent change to it in rails/rails@1962e8d but that doesn't explain my change which reduced the number of CI failures.
KaanOzkan
force-pushed
the
ko/fix-ci-4
branch
3 times, most recently
from
f3b6a2e
to
cb9dc71
Compare
KaanOzkan
force-pushed
the
ko/fix-ci-4
branch
from
3ae2d03
to
a456ca1
Compare
Development version of sqlite3 used by tapioca seems to leak into the tests. I don't fully understand it however, one solution is sticking to the coupling between ActiveRecord and sqlite3 versions https://github.com/rails/rails/blob/dd8f7185faeca6ee968a6e9367f6d8601a83b8db/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb#L14
Not needed after the previous commit
Not sure why yet 😬
KaanOzkan
force-pushed
the
ko/fix-ci-4
branch
from
cd40979
to
1ecf288
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix CI
Implementation
Tests