Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler for GraphQL::Schema #1733

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Compiler for GraphQL::Schema #1733

wants to merge 1 commit into from

Conversation

amomchilov
Copy link
Contributor

Motivation

Which creates a strongly-typed sig for #context, if the context class was customized via the context_class DSL.

For Shopify employees, please see the timeline for a link to a PR with a sample application of this compiler.

Implementation

I copied the GraphQLMutation compiler and edited it.

Tests

I copied the tests for the GraphQLMutation compiler and edited those, too. :)

@amomchilov amomchilov added enhancement New feature or request feature labels Dec 15, 2023
@amomchilov amomchilov self-assigned this Dec 15, 2023
@amomchilov amomchilov requested a review from a team as a code owner December 15, 2023 20:07
@amomchilov amomchilov force-pushed the Alex/GraphQL_Schema branch 3 times, most recently from 39a01df to c0216ac Compare December 15, 2023 20:11
Which creates a strongly-typed sig for `#context`, if the context class was customized via the `context_class`  DSL.
@amomchilov
Copy link
Contributor Author

You set the context class on the Schema, but you don't actually ever read it from the Schema 🤦

I'll rework this to add sigs to the correct classes, like GraphQL::Schema::Resolver, GraphQL::Schema::Mutation, etc.

@amomchilov amomchilov marked this pull request as draft December 15, 2023 21:45
@KaanOzkan KaanOzkan removed their request for review July 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant