Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics for situations where Rails fails to boot #520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve diagnostics for situations where Rails fails to boot #520

wants to merge 1 commit into from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Nov 7, 2024 •
edited
Loading

Closes #519

@andyw8 andyw8 requested a review from a team as a code owner November 7, 2024 20:30
@andyw8 andyw8 force-pushed the andyw8/improve-boot-diagnostics branch from fe69011 to e397cac Compare November 7, 2024 21:20
@andyw8 andyw8 force-pushed the andyw8/improve-boot-diagnostics branch from e397cac to 4e9346a Compare November 7, 2024 21:21
andyw8
andyw8 commented Nov 7, 2024
View reviewed changes
lib/ruby_lsp/ruby_lsp_rails/runner_client.rb
@@ -109,7 +109,7 @@ def initialize(outgoing_queue)
end,
Thread,
)
rescue Errno::EPIPE, IncompleteMessageError
rescue Errno::EPIPE, IncompleteMessageError, MessageError
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Perhaps we should rescue any StandardError here?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me.

@andyw8 andyw8 requested a review from KaanOzkan November 7, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan Awaiting requested review from KaanOzkan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve diagnostics for situations where Rails fails to boot
2 participants
@andyw8 @KaanOzkan