Chloe/oa dropzone keyboardevents #11713
Closed
+203
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloerice
commented
Mar 11, 2024
| @@ -72,8 +76,8 @@ export function WithALabel() { | |||
| } | |||
|
|
|||
| export function WithImageFileUpload() { | |||
| const [files, setFiles] = useState([]); | |||
| const [rejectedFiles, setRejectedFiles] = useState([]); | |||
| const [files, setFiles] = useState<File[]>([]); | |||
There was a problem hiding this comment.
(FIxed type errors throughout the file in addition to making the new story fully functional)
chloerice
commented
Mar 11, 2024
| onClick={handleModalToggle} | ||
| onDrop={handleThumbnailDrop} | ||
| > | ||
| <UnstyledButton style={thumbnailStyle} onKeyUp={handleKeypress}> |
There was a problem hiding this comment.
The interactive child should probably be configured to handle click event instead of the DropZone's wrapper div)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
aaronccasanova
force-pushed
the
oa-dropzone-keyboardevents
branch
from
6d8b5bd
to
a0e6f77
Compare
aaronccasanova
force-pushed
the
chloe/oa-dropzone-keyboardevents
branch
from
7b336b6
to
5df6c82
Compare
|
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes