Skip to content

Commit

Permalink
Upgrade storybook packages from 8.0.9 to 8.4.1 (#12881)
Browse files Browse the repository at this point in the history
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Open it as a draft if it’s a work in progress
-->

### WHY are these changes introduced?

The `pnpm-lock.yaml` file is currently broken in main:
```
ERR_PNPM_BROKEN_LOCKFILE  The lockfile at "/home/runner/work/polaris/polaris/pnpm-lock.yaml" is broken: duplicated mapping key (8175:3)

 [8](https://github.com/Shopify/polaris/actions/runs/11707524346/job/32607095304#step:7:9)172 |       '@babel/core': 7.26.0
```

### WHAT is this pull request doing?

This PR is upgrading the remaining Storybook packages from `8.0.0` to
`8.4.1` which fixes the build and unblocks CI.
It should also close the remaining Storybook dependabot PRs.

I've confirmed that `pnpm install && pnpm build` runs locally now, and
I'm able to run Storybook locally again.

<details><summary>Screenshot</summary>
<p>

![Screenshot 2024-11-07 at 6 02
35 PM](https://github.com/user-attachments/assets/d5f4d32f-1fb8-444e-80a9-d04dc2344090)

</p>
</details> 


### How to 🎩

🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)




### 🎩 checklist

- [ ] Tested a
[snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases)
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
  • Loading branch information
Germanika authored Nov 8, 2024
1 parent 9cf8193 commit 356c1bc
Show file tree
Hide file tree
Showing 2 changed files with 187 additions and 433 deletions.
Loading

0 comments on commit 356c1bc

Please sign in to comment.