Run AppWatcher as a dev process #4828
Conversation
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1927 tests passing in 876 suites. Report generated by 🧪jest coverage report action from 72841f6 |
| @@ -57,8 +51,10 @@ export class ESBuildContextManager { | |||
| resolveDir: extension.directory, | |||
| loader: 'tsx', | |||
| }, | |||
| stderr: this.stderr ?? process.stderr, | |||
| stdout: this.stdout ?? process.stdout, | |||
| logLevel: 'silent', | |||
There was a problem hiding this comment.
What's the reason/effect behind this change?
There was a problem hiding this comment.
Stdout and stderr are actually ignored by esbuild, it always prints to process.stdout which breaks our custom concurrent output.
To solve that, we configure esbuild to be silent, and the errors are printed with the right format by the app-event-watcher (see the usage of formatMessageSync inside a useConcurrentOutputContext
| // eslint-disable-next-line no-catch-all/no-catch-all, @typescript-eslint/no-explicit-any | ||
| } catch (error: any) { | ||
| return {status: 'error', error: error.message, handle: ext.handle} as const | ||
| // If there is an `errors` array, it's an esbuild error, format it and log it |
There was a problem hiding this comment.
Do we have something that covers this behaviour in tests? i.e. making sure we don't regress on how we want these errors to be handled
There was a problem hiding this comment.
I don't think so, will add them
WHY are these changes introduced?
We want to use the AppWatcher globally by all the other processes, this way any process can subscribe to app changes during dev.
WHAT is this pull request doing?
AppWatcherProcessthat starts the App WatcherDevSessionProcessBuildResultin each extension event -> To know if the extension was successfully built after the detected change.How to test your changes?
Run
app devwith the app management API.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist