Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default timeout to 60s #36

Merged
merged 2 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@
### Bug Fixes

* Update publish to Gem API Key ([3f9c8e5](https://github.com/ShipEngine/shipengine-ruby/commit/3f9c8e5eec8147e2fb1b38a114fa0e2ff24a5f9e))

## [1.0.4]

### Changes

* increase default timeout from 30s to 60s
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
shipengine_sdk (1.0.3)
shipengine_sdk (1.0.4)
faraday (>= 1.4)
faraday_middleware (>= 1.0)
hashie (>= 3.4)
Expand Down
2 changes: 1 addition & 1 deletion lib/shipengine/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def initialize(api_key:, retries: nil, timeout: nil, page_size: nil, base_url: n
@api_key = api_key
@base_url = base_url || Constants.base_url
@retries = retries || 1
@timeout = timeout || 30_000
@timeout = timeout || 60_000
@page_size = page_size || 50
validate
end
Expand Down
2 changes: 1 addition & 1 deletion lib/shipengine/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# frozen_string_literal: true

module ShipEngine
VERSION = '1.0.3'
VERSION = '1.0.4'
end
2 changes: 1 addition & 1 deletion test/internal_client/configuration_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
client = ShipEngine::Client.new('foo')

# the global configuration should not be mutated
assert_equal 30_000, client.configuration.timeout
assert_equal 60_000, client.configuration.timeout
assert_equal 50, client.configuration.page_size
end
it 'the global config should not be mutated if overridden at method call time' do
Expand Down