Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft PR with multiple changes #35

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

leonid-s-usov
Copy link

Hi,

found your fork as the only one actually contributing to the project.
I have this local branch where I had to add a number of features which I believe can be useful to others.

Let's see if this makes sense. I don't have too much time but probably can refactor things if it will be needed

The major changes here are

  • Preserving the order of the encode calls in the output XML
  • Compliant approach to treating empty elements. Such elements should return value "". The only standard way to have an element read as nil is to utilise the xsi:nil="true" attribute.

regexident and others added 23 commits October 27, 2018 16:55
# Conflicts:
#	Sources/XMLParsing/XMLStackParser.swift
If these are the exactly correct versions needs to be tested
@MaxDesiatov
Copy link

Hi @leonid-s-usov, I see this has commits from XMLCoder, was this actually meant to be a PR in that repository?

@regexident
Copy link

Given …

found your fork as the only one actually contributing to the project.

… OP probably meant XMLCoder, yeah. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants