Update and fixes #255
Open
Update and fixes #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper error message when editing a schedule sync list while no sync tasks were created
Fix Non Wrap Text View should be wrapped for error dialog messages in "Edit Schedule sync task list"
- Simpler code - Always warn first if file is ignored because its name length is greater than user selected limit. Else, warn that it is ignored by SMB file name length limit
Also upgrade JcifsFile to 1.10
Version upgrades only need editing SYNC_FOLDER_SMB_PROTOCOL_SMB_LATEST_VERSION variable
Sync jcifs-ng to upstream source
Fix a few errors Detail filters v2 as it is now the recommended option (+2 years of testing)
Replace Master with Source in GUI as it is no longer used in current sync programs
Use enhanced directory filter was enabled by default while it should default to not: use SyncTaskItem to get proper defaults
- Add a context help button to filter selection dialog. Clicking the help button will toggle the quick help guide for file and directory name filters. - Add filter v1 quick help guide
Translate quick help guides for name filters v1 and v2
Help button will toggle the quick guide for "Edit Wifi IP Address" filter dialog
On touch, dismiss the filter dialog warning that "Remove folders and files excluded by name filters" option is enabled in mirror mode
Messages and history could be overwritten on app reinstall and when re-requesting storage access permissions
rebuild lib, no code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes + I implemented new ALL_FILES_ACCESS in SMBSync2
However, fixing USB drive storage access needs a huge rewrite of the adapters and even the StorageManager
I will look at SMBSync3 and eventually maintain the code if you drop it
Feel free to merge this if you will to maintain SMBSync2