Issue #7122 Burmese Flag correction #7123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of the add/deletion is based on the rc settings from the original library to just make css prettier. However, the key update here is: Fixed with this PR! |
arkhamRejek
approved these changes
Dec 21, 2023
|
is the project abandoned? |
honestly I am not sure. the PR was approved last December, but no one merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Titles
#7122
[Flag] - Shows the Flag of Taiwan when try to use Burmese Flag #7122
Description
Was reading the documentation here:
https://react.semantic-ui.com/elements/flag/#types-flag
but realized that the main example uses the Taiwan flag but in the code, it says Myanmar
Testcase
Expected
When using Myanmar flag:
Instead of Showing 🇹🇼 should show 🇲🇲
Result
Currently shows 🇹🇼 when using the Myanmar flag