Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tasks/config/tasks] Fixes Autoprefixer warnings in build log #6887

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

nitzel
Copy link

@nitzel nitzel commented Oct 23, 2019

[Tasks/config/tasks] Fixes Autoprefixer warnings in build log

Closed Issues

No issues opened that relate to this.

Description

Removed autoprefixer warnings from build log by renaming settings.prefix.browsers to overrideBrowserslist.

Warnings looked like:

Replace Autoprefixer browsers option to Browserslist config.
Use browserslist key in package.json or .browserslistrc file.

Using browsers option cause some error. Browserslist config 
can be used for Babel, Autoprefixer, postcss-normalize and other tools.

If you really need to use option, rename it to overrideBrowserslist.

Learn more at:
https://github.com/browserslist/browserslist#readme
https://twitter.com/browserslist

jlukic and others added 4 commits October 21, 2018 13:56
…fig/tasks.js

Renamed `settings.prefix.browsers` to `overrideBrowserslist` to get rid of the following warning when building:

```
Replace Autoprefixer browsers option to Browserslist config.
Use browserslist key in package.json or .browserslistrc file.

Using browsers option cause some error. Browserslist config 
can be used for Babel, Autoprefixer, postcss-normalize and other tools.

If you really need to use option, rename it to overrideBrowserslist.

Learn more at:
https://github.com/browserslist/browserslist#readme
https://twitter.com/browserslist
```
@nitzel
Copy link
Author

nitzel commented Oct 23, 2019

Ah it looks like I chaning master and now want to merge into next - should re-do the PR by changing next instead?

@y0hami
Copy link
Member

y0hami commented Oct 23, 2019

@nitzel

Take a look at Fomantic-UI (https://github.com/fomantic/Fomantic-UI)

NOTE: Fomantic was created to continue active development of Semantic-UI and has the intent to be merged back into the master repository once active development can restart. For more info please read the following issues #6109 #6413

@GammaGames
Copy link
Contributor

@nitzel If you're curious why Fomantic-UI as suggested, look at the date for the most recent commit on this repo

@nitzel
Copy link
Author

nitzel commented Oct 24, 2019

@GammaGames I saw that but wishful thinking took over. I'm using patch-package for now to fix it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants