Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose pvc retention policy via helm #6056

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from

Conversation

abhimanyu003
Copy link
Member

@abhimanyu003 abhimanyu003 commented Nov 13, 2024

What this PR does / why we need it:

Expose PVC retention policy via helm. Retain is the default value.
Info on retention policy can be found here: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#persistentvolumeclaim-retention

Example YAML

apiVersion: mlops.seldon.io/v1alpha1
kind: Server
  name: triton
  namespace: seldon
spec:
  replicas: 1
  serverConfig: triton
  statefulSetPersistentVolumeClaimRetentionPolicy:
    whenDeleted: Retain
    whenScaled: Retain

Fixes #INFRA-1235

Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a minor comment.

Has this been tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants