Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Changes from v2 for release 2.8.5 (3) #6023

Merged
merged 3 commits into from
Nov 1, 2024
Merged

fix(ci): Changes from v2 for release 2.8.5 (3) #6023

merged 3 commits into from
Nov 1, 2024

Commits on Nov 1, 2024

  1. fix(agent): allow serial order for servers connection per instance (#… 

    …6020)


* enforce serial order on agent connections

* add serial order for dataflow engine

* move logging after acquiring lock

* lint fixes

* add tests for chainer subscribe

* increase sleep to fix flaky test
    @sakoush
    sakoush authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    520ba61 View commit details
    Browse the repository at this point in the history

  2. fix(ci): fix flaky test (#6022) 

    * fix flaky test

* cap execution of test in case of failures
    @sakoush
    sakoush authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cb5cfbd View commit details
    Browse the repository at this point in the history

  3. fix(dataflow): make each replica use unique subscription names (#6021) 

    Following #6020, it was no longer possible to have multiple replicas of dataflow-engine subscribing simultaneously to the scheduler, because all were connecting with the same subscriber name, and a lock was added per name, first waiting the disconnection of the old subscriber before allowing a new one to progress.

We update the dataflow-engine code so that each replica connects with its own hostname as the subscriber name. If the hostname can not be determined, we subscribe with the name seldon-dataflow-engine- followed by the canonical string representation of a UUID v4.

The subscriber name can also be explicitly controlled by passing the --dataflow-replica-id argument or the DATAFLOW_REPLICA_ID environment variable, wich will take precedence, in that order, to setting the value as the hostname.
    @lc525
    lc525 authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2c79e77 View commit details
    Browse the repository at this point in the history