fix(scheduler): Manual trigger envoy update #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
changed the title
ukclivecox
reviewed
Aug 11, 2023
| func (p *IncrementalProcessor) modelSync() { | ||
| logger := p.logger.WithField("func", "modelSync") | ||
| func (p *IncrementalProcessor) triggerModelSyncIfNeeded() bool { | ||
| if p.batchTriggerManual == nil { |
There was a problem hiding this comment.
add comment on why we do this for clarity
ukclivecox
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In some cases under heavy load, periodic batched envoy model update does not get a fair chance to run due to lock contention. This fix introduces a manual trigger as well (which does not require to release the lock and therefore is guaranteed to proceed).
This PR also adds:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: