Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-556 allow flavors with gpu in jupyter labs #246

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hamzaimran08
Copy link
Collaborator

Description

This change relates to issue SS-556. Jupyter Labs are allowed to be allocated GPUs if the environment is configured to have GPUs.

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@hamzaimran08 hamzaimran08 self-assigned this Oct 27, 2024
@hamzaimran08 hamzaimran08 requested a review from a team October 28, 2024 08:27
@hamzaimran08 hamzaimran08 changed the title allow flavors with gpu in jupyter labs SS-556 allow flavors with gpu in jupyter labs Oct 28, 2024
Copy link
Contributor

@churnikov churnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why make this restriction, when flavors can be created only by us?

@hamzaimran08
Copy link
Collaborator Author

Why make this restriction, when flavors can be created only by us?

Because the same Flavor can be used by different apps as well and then they will have GPUs allocated and we don't want that. Right now we only want to test with Jupyter Labs.

Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few unit tests verifying creating a new gpu based flavor for JL notebooks and not being able to create for other app types would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants