Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-643 Users can edit their account details #235

Merged
merged 30 commits into from
Oct 22, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d321a3f
Updated info about using Serve for teaching (#194)
akochari Apr 19, 2024
2b5cadc
Revert "Updated info about using Serve for teaching (#194)"
akochari Apr 19, 2024
2d769be
Merge branch 'staging' into main
sandstromviktor May 23, 2024
ab7d54f
Merge branch 'staging'
churnikov Aug 14, 2024
46f589c
Merge branch 'staging'
churnikov Sep 19, 2024
c958069
SS-643-Make-an-option-to-edit-account-details
anondo1969 Oct 7, 2024
7c8099b
SS-643-Make-an-option-to-edit-account-details
anondo1969 Oct 7, 2024
4e3de76
SS-643 extending ProfileForm
anondo1969 Oct 8, 2024
d38f4ce
SS-643 Updated edit HTML form
anondo1969 Oct 10, 2024
d86a443
SS-643 Updated edit HTML form
anondo1969 Oct 10, 2024
32b49eb
SS-643 pre-commit check fixed
anondo1969 Oct 10, 2024
bba6f8b
SS-643 pre-commit with black check
anondo1969 Oct 10, 2024
0048d66
SS-643 pre-commit with black check 2
anondo1969 Oct 10, 2024
cf33450
Merge branch 'develop' into SS-643-Make-an-option-to-edit-account-det…
anondo1969 Oct 14, 2024
cded668
fix failing e2e test
akochari Oct 14, 2024
8194013
change the edit profile icon
akochari Oct 14, 2024
a05bf15
uncomment the line I accidentally commented out
akochari Oct 14, 2024
ee23c4e
Update common/views.py
anondo1969 Oct 15, 2024
b3481fd
Update common/forms.py
anondo1969 Oct 15, 2024
6bb12aa
Update common/forms.py
anondo1969 Oct 15, 2024
41b2862
fix super class init.
anondo1969 Oct 15, 2024
491b6f8
changes in view
anondo1969 Oct 15, 2024
da00974
ensure login required in form post method
anondo1969 Oct 15, 2024
f78edf6
Merge branch 'develop' into SS-643-Make-an-option-to-edit-account-det…
anondo1969 Oct 15, 2024
7f13f1e
ensuring curl injection does not work
anondo1969 Oct 17, 2024
a96fdfd
fixing the profile-edit bug in superuser mode
anondo1969 Oct 21, 2024
5a7fa52
Merge branch 'develop' into SS-643-Make-an-option-to-edit-account-det…
anondo1969 Oct 21, 2024
0d50532
Merge branch 'develop' into SS-643-Make-an-option-to-edit-account-det…
anondo1969 Oct 21, 2024
2d11a65
differentiate admin user and common user with or without Staff/Superu…
anondo1969 Oct 22, 2024
ce5e4a8
differentiate admin user and common user with or without Staff/Superu…
anondo1969 Oct 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion common/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
from common.models import EmailVerificationTable, UserProfile
from studio.utils import get_logger

from django.utils.translation import gettext_lazy as _

logger = get_logger(__name__)


Expand Down Expand Up @@ -370,7 +372,7 @@ class Meta:
def __repr__(self) -> str:
return f"{self.__class__.__name__}({self.data})"

'''
class ProfileEditForm(BootstrapErrorFormMixin, forms.ModelForm):
affiliation = forms.ChoiceField(
widget=forms.Select(attrs={"class": "form-control"}),
Expand Down Expand Up @@ -403,4 +405,44 @@ class Meta:

def __repr__(self):
return f"{self.__class__.__name__}({self.data})"
'''

class ProfileEditForm(ProfileForm):


class Meta(ProfileForm.Meta):

exclude = ["note",
"why_account_needed",]

def __init__(self, *args, **kwargs):
super(ProfileEditForm, self).__init__(*args, **kwargs)
anondo1969 marked this conversation as resolved.
Show resolved Hide resolved
self.fields["affiliation"].disabled=True
#self.fields["affiliation"].required = False
self.fields["affiliation"].help_text="Affiliation can not be changed. Please email [email protected] with any questions."

'''
class UserEditForm(UserForm):


class Meta(UserForm.Meta):

exclude = [
"username",
"password1",
"password2",
]
def __init__(self, *args, **kwargs):
super(UserEditForm, self).__init__(*args, **kwargs)
self.fields["email"].disabled=True
self.fields["email"].help_text="Email address can not be changed. Please email [email protected] with any questions."
del self.fields["password1"]
del self.fields["password2"]
self.fields["email"].required = False
'''






10 changes: 7 additions & 3 deletions common/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ def get(self, request, *args, **kwargs):
profile_edit_form = self.profile_edit_form_class(initial={
"affiliation" : user_profile_data.affiliation,
"department" : user_profile_data.department
})
})


user_edit_form = self.user_edit_form_class(initial={
"email" : user_profile_data.user.email,
"first_name" : user_profile_data.user.first_name,
Expand Down Expand Up @@ -206,7 +208,9 @@ def post(self, request, *args, **kwargs):
# was invalid

#print (form.errors)
logger.error("Edit user error: " + str(user_form_details.errors), exc_info=True)
logger.error("Edit profile error: " + str(profile_form_details.errors), exc_info=True)
if user_form_details.is_valid()==False:
anondo1969 marked this conversation as resolved.
Show resolved Hide resolved
logger.error("Edit user error: " + str(user_form_details.errors), exc_info=True)
if profile_form_details.is_valid()==False:
anondo1969 marked this conversation as resolved.
Show resolved Hide resolved
logger.error("Edit profile error: " + str(profile_form_details.errors), exc_info=True)

return render(request, self.template_name, {"form": user_form_details, "profile_form": profile_form_details})
Loading