Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.5.0 release PR - "Able adenine" #14

Merged
merged 36 commits into from
Jun 28, 2024
Merged

Version 1.5.0 release PR - "Able adenine" #14

merged 36 commits into from
Jun 28, 2024

Conversation

MatthiasZepper
Copy link
Member

@MatthiasZepper MatthiasZepper commented Jun 17, 2024

New and Improved Features:

  • Since this release, umi-transfer features internal multi-threaded output compression. As a result, umi-transfer 1.5 now runs approximately 25 times faster than version 1.0 when using internal compression and about twice as fast compared to using an external compression tool via a buffered pipe.
  • The new CLI arguments -t, --threads <NUM_THREADS> and -l, --compression_level <COMPRESSION_LEVEL> have been introduced accordingly. The compression level defaults to 3. Higher numbers result in marginally smaller files but take significantly longer to compress. For the number of threads, we recommend 9 or 11, if a sufficient number of logical cores are available.
  • The Docker base image has been updated from Debian Bullseye (Version 11) to Debian Bookworm (Version 12).
  • Improved integration tests, including CLI prompts.
  • Updates to the internal Rust libraries and dependencies.

Discontinued Previous Features:

  • None

MatthiasZepper and others added 30 commits May 6, 2024 18:28
…afely the trait Send is not implemented for dyn ZWriter
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@ace1547). Learn more about missing BASE report.

Files Patch % Lines
src/auxiliary.rs 75.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   88.10%           
=======================================
  Files           ?        5           
  Lines           ?      185           
  Branches        ?        0           
=======================================
  Hits            ?      163           
  Misses          ?       22           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alneberg alneberg self-requested a review June 25, 2024 11:32
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No YOLO for you. 👍

@MatthiasZepper MatthiasZepper merged commit 677f59b into main Jun 28, 2024
17 of 18 checks passed
@MatthiasZepper
Copy link
Member Author

This PR is merged despite failing CI tests, because the one failing test pertains to the code test coverage: No patches must have a lower coverage than the overall coverage of the project.

But for that particular file, testing the remaining three lines of code would require mocking hardware detection failures. These tests are very hard to implement and unhelpful with regard to umi-transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants