-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.5.0 release PR - "Able adenine" #14
Conversation
… umi-transfer fails.
…afely the trait Send is not implemented for dyn ZWriter
…ing them to the output file.
…the rexpect crate.
…e max_threads for each.
Co-authored-by: Johannes Alneberg <[email protected]>
Polishing for 1.5 release
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage ? 88.10%
=======================================
Files ? 5
Lines ? 185
Branches ? 0
=======================================
Hits ? 163
Misses ? 22
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No YOLO for you. 👍
This PR is merged despite failing CI tests, because the one failing test pertains to the code test coverage: No patches must have a lower coverage than the overall coverage of the project. But for that particular file, testing the remaining three lines of code would require mocking hardware detection failures. These tests are very hard to implement and unhelpful with regard to |
New and Improved Features:
-t
,--threads <NUM_THREADS>
and-l
,--compression_level <COMPRESSION_LEVEL>
have been introduced accordingly. The compression level defaults to 3. Higher numbers result in marginally smaller files but take significantly longer to compress. For the number of threads, we recommend 9 or 11, if a sufficient number of logical cores are available.Discontinued Previous Features: