Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the MultiCV hack since it's become available #16893

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the MultiCV hack since it's become available #16893

wants to merge 1 commit into from

Conversation

vsedmik
Copy link
Contributor

@vsedmik vsedmik commented Nov 11, 2024

Problem Statement

MultiCV has become available in 6.17 via setting, no hacks are needed anymore.

Solution

Just remove the helper from mixins and fixture.

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k multi_cv

@vsedmik vsedmik added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Nov 11, 2024
@vsedmik vsedmik requested a review from a team November 11, 2024 16:38
@vsedmik vsedmik self-assigned this Nov 11, 2024
@vsedmik vsedmik requested a review from a team as a code owner November 11, 2024 16:38
@vsedmik
Copy link
Contributor Author

vsedmik commented Nov 11, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py -k multi_cv

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9326
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_host.py -k multi_cv --external-logging
Test Result : ==== 2 passed, 88 deselected, 322 warnings, 6 errors in 1613.89s (0:26:53) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 11, 2024
chris1984
chris1984 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jeremylenz
Copy link
Contributor

PRT will fail until foreman_theme_satellite is released and in Stream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pondrejk pondrejk pondrejk approved these changes

@chris1984 chris1984 chris1984 approved these changes

Assignees

@vsedmik vsedmik

Labels
No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsedmik @Satellite-QE @jeremylenz @chris1984 @pondrejk