-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend manifest labels test case with manifest_lists #16878
Open
vsedmik
wants to merge
2
commits into
SatelliteQE:master
Choose a base branch
from
vsedmik:extend-manifest-labels
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsedmik
added
No-CherryPick
PR doesnt need CherryPick to previous branches
Stream
Introduced in or relating directly to Satellite Stream/Master
labels
Nov 6, 2024
trigger: test-robottelo |
PRT Result
|
Satellite-QE
added
the
PRT-Failed
Indicates that latest PRT run is failed for the PR
label
Nov 6, 2024
PRT Result
|
And extend it with manifest_lists.
synkd
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing specifically for the change to the new upgrade format, everything looks good there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
No-CherryPick
PR doesnt need CherryPick to previous branches
PRT-Failed
Indicates that latest PRT run is failed for the PR
Stream
Introduced in or relating directly to Satellite Stream/Master
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
Solution
share_resource
approach.CODEOWNERS
file with the new upgrade files.Related Issues
https://issues.redhat.com/browse/SAT-27490
PRT test Cases example
Requires
Katello/katello#11172
SatelliteQE/nailgun#1240 (merged)
For the new-style upgrade scenario we need to wait for the 11172 being packed in next snap.