Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.11.z] UI Utils module depreciation and new ui_factory module #12644

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #12225

  • Depreciating UI Utils module, removed UI utils file and package!
  • Introduced new ui_factory attribute to satellite class, returns the UIFactory class object containing all the UI Factory methods.
    So now this could be used as target_sat.ui_factory.ui_method()
  • Impacted test modules changed to use ui_factory methods.

@Satellite-QE Satellite-QE added 6.11.z Introduced in or relating directly to Satellite 6.11 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Sep 18, 2023
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k test_positive_generate_registered_hosts_report

@Gauravtalreja1
Copy link
Collaborator

trigger: test-robottelo
pytest: tests/foreman/ui/test_reporttemplates.py -k test_positive_generate_registered_hosts_report

@Gauravtalreja1 Gauravtalreja1 force-pushed the cherry-pick-6.11.z-ab2102352e0137f7148448c764587f71df7ce1d3 branch from f9a394e to 89b8bcb Compare September 20, 2023 18:32
@Gauravtalreja1
Copy link
Collaborator

@jyejare we're not supposed to cherrypick anything to this branch. PRT is failing with checks, so are you going to work on this PR?

@jyejare
Copy link
Member

jyejare commented Sep 21, 2023

@Gauravtalreja1 Yeah! I mean we have cli and API factory changes made in 6.11 and I dont want to miss just ui factory changes. Will fix and update !

Depreciation of UI Utils

(cherry picked from commit ab21023)
@jyejare jyejare force-pushed the cherry-pick-6.11.z-ab2102352e0137f7148448c764587f71df7ce1d3 branch from 89b8bcb to a2d0434 Compare September 21, 2023 08:57
@jyejare
Copy link
Member

jyejare commented Sep 21, 2023

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py

1 similar comment
@devendra104
Copy link
Member

trigger: test-robottelo
pytest: tests/foreman/ui/test_host.py

@jyejare
Copy link
Member

jyejare commented Sep 21, 2023

@Gauravtalreja1 The required changes are updated to fix the CI checks tests collection and PRT is ran. PRT failures are not related to the change made in this PR !

@Gauravtalreja1 Gauravtalreja1 merged commit c3223c7 into 6.11.z Sep 22, 2023
4 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.11.z-ab2102352e0137f7148448c764587f71df7ce1d3 branch September 22, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.11.z Introduced in or relating directly to Satellite 6.11 Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants