Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added json output of equalizer information of the device #358

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Added json output of equalizer information of the device #358

merged 2 commits into from
Jul 22, 2024

Conversation

nicola02nb
Copy link
Contributor

@nicola02nb nicola02nb commented Jun 19, 2024 •
edited
Loading

Changes made

  • EqualizerInfo and EqualizerPreset and EqualizerPresets structs
  • Added EqualizerInfo and EqualizerPreset and EqualizerPresets structs to device struct
  • Added json output for EqualizerPreset and EqualizerPresets
  • Refactor of steelseries_arctis_nova_7.c for adding support of the new info to output

Checklist

  • I adjusted the README (if needed)
  • For new features in HeadsetControl: I discussed it beforehand in Issues or Discussions and adhered to the wiki

@nicola02nb
Copy link
Contributor Author

Just seen I've broken the --equalizer feature

@nicola02nb nicola02nb closed this Jun 21, 2024
@nicola02nb nicola02nb reopened this Jun 21, 2024
@nicola02nb
Copy link
Contributor Author

@Sapd I think that the check-whitespace fail is caused by the deprecated use of set-output in echo "::set-output name=checkout::"${log}"".
The fix should be somethin like this: echo "checkout=${log}" >> $GITHUB_OUTPUT, if I'm not wrong

@Sapd
Copy link
Owner

Sapd commented Jul 4, 2024

Yep dont worry about the whitespace error. I will check the PR on the weekend

@nicola02nb
Copy link
Contributor Author

Yeah, no problem, it was olny a suggetsion :)

nicola02nb and others added 2 commits July 22, 2024 16:12
@nicola02nb @Sapd
Added equalizer info for artico nova pro wireless, artic nova 3, arti…
48a56af 
…c nova 7 plus

Fix a crash caused by get_float_data_from_parameter() function and added allocatioo and deallocation for equalizer bands_values

Added Bands step for equalizer info; changed equlalizer preset values type; added equalizer info and refactor in steelseries_artic_nova_7.c

Added equalizer and equalizer preset output  json info
@Sapd
Increase api version
8d16f38 
utility: Make get_byte_data behave the same way

Add equalizer info also as JSON
@Sapd Sapd merged commit 5da7092 into Sapd:master Jul 22, 2024
5 checks passed
@Sapd
Copy link
Owner

Sapd commented Jul 22, 2024

Thank you! sorry for the delay. I also added YAML output

@nicola02nb
Copy link
Contributor Author

No worries, thanks for your work.
If you want give a look to the GUI that I created on my gh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicola02nb @Sapd